Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#310] CachedQuotas.analyze creates unnecessary HashSets #313

Merged
merged 1 commit into from
Apr 10, 2022

Conversation

pjeli
Copy link
Collaborator

@pjeli pjeli commented Apr 10, 2022

Make sure you have checked all steps below.

GitHub Issue

Fixes #310

Checklist:

  • This pull request updates the documentation
  • This pull request changes the code
  • Title of the PR is of format (example) : [#25] Add Pull Request Template, where [#25] is the GitHub issue number

What is the purpose of this pull request?

How was this change validated?

Commit Guidelines

  • My commits all reference GH issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov
Copy link

codecov bot commented Apr 10, 2022

Codecov Report

Merging #313 (b8c99e9) into master (ea294f9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #313      +/-   ##
============================================
+ Coverage     74.31%   74.34%   +0.02%     
- Complexity     1075     1076       +1     
============================================
  Files            56       56              
  Lines          7083     7082       -1     
  Branches        638      638              
============================================
+ Hits           5264     5265       +1     
+ Misses         1423     1422       -1     
+ Partials        396      395       -1     
Impacted Files Coverage Δ
...adoop/hdfs/server/namenode/cache/CachedQuotas.java 86.13% <100.00%> (-0.14%) ⬇️
...menode/analytics/web/NamenodeAnalyticsMethods.java 68.87% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea294f9...b8c99e9. Read the comment docs.

@pjeli pjeli merged commit e7f15f2 into paypal:master Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CachedQuotas.analyze creates unnecessary HashSets
1 participant