fix(ui): reset pagination when typing in WhereBuilder select menu #10551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests for this could have been written within the Admin > List View e2e test suite under the "filters" describe block. See this file: https://github.com/payloadcms/payload/blob/main/test/admin/e2e/list-view/e2e.spec.ts. Or alternatively under the Fields > Collections > Relationship e2e suite. |
|
🚀 This is included in version v3.17.0 |
GermanJablo
added a commit
that referenced
this pull request
Jan 20, 2025
…#10553) Following #10551, I found and fixed a handful more bugs: - When writing to the input, the results that were already there were not cleaned, causing incorrect results to appear. - the scroll was causing an infinite loop that showed repeated elements - optimization: only the required field is selected (not required) - refs are set to the initial value to avoid a state where nothing can be searched
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After working on this I found a more accurate way to reproduce the bug:
Fixes #10496
I'd like to do integration testing. But since there is no isolated
/uitest yet, this requires some planning. I have it pending.