fix(next): ensures req.locale is populated before running access control #10533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobsfletch
changed the title
jacobsfletch
changed the title
DanRibbens
approved these changes
Jan 13, 2025
|
🚀 This is included in version v3.17.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10529. The
req.localeproperty within collection and global access control functions does not reflect the current locale. This was because we were attaching the locale to the req only after runningpayload.auth, which attempts to get access control without a fully-formed req. The fix is to first authenticate the user using theexecuteAuthStrategiesoperation directly, then determine the request locale with that user, and finally get access results with the proper locale.