-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to disable cache tags for admin thumbnails #10319
Merged
paulpopus
merged 11 commits into
main
from
feat/add-ability-to-disable-cache-tags-for-admin-thumbnails
Jan 13, 2025
Merged
feat: add ability to disable cache tags for admin thumbnails #10319
paulpopus
merged 11 commits into
main
from
feat/add-ability-to-disable-cache-tags-for-admin-thumbnails
Jan 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanRibbens
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I added one suggestion to consider.
@paulpopus @DanRibbens, thanks for your work on this. Are we able to get it merged and into the next release? |
paulpopus
deleted the
feat/add-ability-to-disable-cache-tags-for-admin-thumbnails
branch
January 13, 2025 15:26
🚀 This is included in version v3.17.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
cacheTags: boolean
(defaulttrue
) to allow users to disable the appended document updatedAt value in the case of hosting with third party CDNs which may not allow additional search params and throw an error.It also fixes how we append this value to consider the case where the URL already contains parameters and appends it with
&
instead.In the future
cacheTags
can be made an object to allow granularity for disablingeTag
headers used for caching as well.The cache tag control should help with these two issues:
InvalidQueryStringException
on Upload's "Edit" view thumbnail #9880The appending of the value correctly addresses this: