AC-37 Split Payara 4 Containers from Payara 5 - (Payara5) #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandrex247
changed the title
|
Hold up, failures on JAXRS-JsonP |
This was referenced Oct 25, 2019
pdudits
approved these changes
Nov 14, 2019
There was a problem hiding this comment.
At first I was bit confused for the reasons for major version change, but I think the main reason is JDK7 compatibility for Payara4, that was unenforced up to now, right?
I still have my doubts about necessity of client-ee* modules, the containers themselves do not need it. I'd argue every usage of @RunAsClient in ee*-samples is incorrect, probably with exception of remote EJBs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the version to 2.0-SNAPSHOT to differentiate it from the Payara4 version.