Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FISH-6456: checking if http2 is enabled #6640

Merged
merged 2 commits into from
Apr 16, 2024
Merged

FISH-6456: checking if http2 is enabled #6640

merged 2 commits into from
Apr 16, 2024

Conversation

luiseufrasio
Copy link
Contributor

@luiseufrasio luiseufrasio commented Apr 15, 2024 •
edited
Loading

Description

This warning is displayed in the log files even though the http2 is disabled:

[2022-06-27T17:32:17.140+0100] [Payara 5.37.0] [WARNING] [] [org.glassfish.grizzly.config.GenericGrizzlyListener] [tid: _ThreadID=45 _ThreadName=RunLevelControllerThread-1656347531709] [timeMillis: 1656347537140] [levelValue: 900] [[
HTTP/2 (enabled by default) is unsupported with port unification and will be disabled for network listener admin-listener.]]

Important Info

Blockers

None

Testing

New tests

None

Testing Performed

  1. Start a Payara server domain
  2. Create a local instance.
  3. Disable HTTP 2 support:
  4. set configs.config.server-config.network-config.protocols.protocol.admin-listener.http.http2-enabled=false
  5. Check for the warning in the log files of the local instance.

Testing Environment

Zulu JDK 11.0.11 on Windows 11 with Maven 3.8.6

Documentation

None

@breakponchito
Copy link
Contributor

Do you think it is possible to add a unit test for this?

breakponchito
breakponchito approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@breakponchito breakponchito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kalinchan kalinchan changed the title FISH-6456: chacking if http2 is enabled FISH-6456: checking if http2 is enabled Apr 16, 2024
@luiseufrasio luiseufrasio merged commit 9900b21 into payara:master Apr 16, 2024
1 check passed
Pandrex247 pushed a commit to Pandrex247/Payara that referenced this pull request Apr 30, 2024
@luiseufrasio @Pandrex247
Merge pull request payara#6640 from luiseufrasio/FISH-6456-remove-htt…
1a419d6 
…p-2-warning

FISH-6456: checking if http2 is enabled
Pandrex247 pushed a commit to Pandrex247/Payara that referenced this pull request May 2, 2024
@luiseufrasio @Pandrex247
Merge pull request payara#6640 from luiseufrasio/FISH-6456-remove-htt…
27114cc 
…p-2-warning

FISH-6456: checking if http2 is enabled
Pandrex247 pushed a commit to Pandrex247/Payara that referenced this pull request May 8, 2024
@luiseufrasio @Pandrex247
Merge pull request payara#6640 from luiseufrasio/FISH-6456-remove-htt…
72d9f5b 
…p-2-warning

FISH-6456: checking if http2 is enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breakponchito breakponchito breakponchito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luiseufrasio @breakponchito