FISH-8482 Adjust Parsing of Version Number #6632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SNAPSHOT snipping was in the wrong place, and the update version can contain non-integers. Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The SNAPSHOT snipping was in the wrong place, and the update version can contain non-integers.
With the current Payara 7 update version being 1.Alpha2-SNAPSHOT, this was getting displayed as "12" (because it was stripping all non-integer values).
Important Info
Blockers
None
Testing
New tests
None
Testing Performed
Built the server, and started the server - nothing amiss about the version in the logs.
Ran the
versionasadmin command - nothing amiss.Loaded the admin console and clicked on "About" at the top to see the full version number - nothing amiss
Loaded Micro - nothing amiss about the version number printed out in the logs.
Testing Environment
Windows 11, Zulu 21.0.2
Documentation
N/A
Notes for Reviewers
None