Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-7430 : send-error_X property being skipped #6556

Conversation

luiseufrasio
Copy link
Contributor

Description

Warning Falsely Logged with Custom Error Pages

Important Info

Blockers

None

Testing

New tests

None

Testing Performed

  1. Replace tag <virtual-server> into domain.xml in Payara Server to:
<virtual-server network-listeners="http-listener-1,http-listener-2" id="server">
        <property name="send-error_1" value="code=404 path=${com.sun.aas.instanceRoot}/docroot/404.html reason=NOT_FOUND"></property>
</virtual-server>
  1. Create a 404.html file in domain1/docroot/
  2. Start server ./asadmin start-domain -v
  3. Warning should NOT be logged during deployment

Testing Environment

Zulu JDK 11 on Windows 11 with Maven 3.8.6

Documentation

None

@luiseufrasio
Copy link
Contributor Author

jenkins test please

Copy link
Contributor

@breakponchito breakponchito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pandrex247 Pandrex247 merged commit 2c584eb into payara:master Feb 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants