Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-7665: fixing issue creating osgi bundle for libpam4j #6348

Conversation

breakponchito
Copy link
Contributor

@breakponchito breakponchito commented Aug 1, 2023

Fixing issue to start server caused by the libpam4j-repackaged.jar dependency

Description

This is fix for a bug when creating the jar bundle for the libpam4j, older version of the maven-bundle-plugin
is generating a jar file with error in zip headers. To fix, it is needed to use last version of
the plugin 5.1.9

Important Info

Blockers

Testing

New tests

Testing Performed

Manual testing with most recent versions of JDK 11 and 17. Now the server can start with both JDK's

Testing Environment

windows 11, Azul JDK 11.0.20 and Azul JDK 17.0.8

Documentation

Notes for Reviewers

@breakponchito
Copy link
Contributor Author

Jenkins test please

1 similar comment
@breakponchito
Copy link
Contributor Author

Jenkins test please

@breakponchito breakponchito merged commit 15b3735 into payara:master Aug 1, 2023
@ctabin
Copy link
Contributor

ctabin commented Aug 2, 2023

Hi, I wonder if this would also be related to #6262 ? 🤔

@Pandrex247
Copy link
Member

It is related, but it's more focussed on fixing #6344.
We can't currently bump the bundle plugin version globally at this point in time due to changes in the expected OSGi imports (see my comment here).

Pending us properly looking into how we intend to deal with OSGi (sprinkling -noimportjava everywhere vs. reconfiguring the imports/exports for JDK packages), we're just incrementing the version here to solve the immediate issue with the zip headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants