FISH-7409: adding property to load com.sun.jndi.ldap classes for jdk 17 #6345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test please |
Pandrex247
requested changes
Jul 25, 2023
appserver/admin/production_domain_template/src/main/resources/config/domain.xml
Show resolved
Hide resolved
appserver/admin/production_domain_template/src/main/resources/config/domain.xml
Show resolved
Hide resolved
appserver/admin/production_domain_template_web/src/main/resources/config/domain.xml
Show resolved
Hide resolved
appserver/admin/production_domain_template_web/src/main/resources/config/domain.xml
Show resolved
Hide resolved
|
Jenkins test please |
Pandrex247
previously approved these changes
Jul 26, 2023
Pandrex247
requested changes
Jul 26, 2023
There was a problem hiding this comment.
You've missed adding the option to the default-config block
There was a problem hiding this comment.
already added
|
Jenkins test please |
Pandrex247
approved these changes
Jul 26, 2023
This was referenced Aug 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding fix to include com.sun.jndi.ldap classes when using jdk 17
Description
This is a fix of a reported bug when trying to use jndi.ldap classes
Important Info
Blockers
Testing
New tests
Testing Performed
Manual testing:
Now the call of the endpoint is responding with 200 from micro, server a web:
No issues from logs using JDK 17
Testing Environment
Ubuntu 20.04, maven 3.8.6, azul jdk 17
Documentation
Notes for Reviewers