Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FISH-7024 Migration to Jakarta Persistence 3.0 namespace for EJB Timer services #6149

Merged
merged 2 commits into from
Jan 25, 2023
Merged

FISH-7024 Migration to Jakarta Persistence 3.0 namespace for EJB Timer services #6149

merged 2 commits into from
Jan 25, 2023

Conversation

ctabin
Copy link
Contributor

@ctabin ctabin commented Jan 12, 2023

Migrate EJB timer services to Jakarta Persistence 3.0 namepace.

This is an attempt to solve #6148 and remove a dependency on Oracle thirt-party website (although it still depends on an external XSD).

@ctabin
Copy link
Contributor Author

ctabin commented Jan 12, 2023

I wonder if the xmlns would even be requiered regarding the persistence.xml in GlassFish... It could be completely removed, hence avoiding any dependency on a third-party website. 🤔

@pzygielo
Copy link
Contributor

Not 100% sure, but after this I suspect the XSD to be solved by AS from the local catalogue to

Payara/appserver/deployment/schemas/src/main/resources/glassfish/lib/schemas/persistence_3_0.xsd

Line 16 in 7455a77

<xsd:schema targetNamespace="https://jakarta.ee/xml/ns/persistence"

with no need to ask external service.

@ctabin
Copy link
Contributor Author

ctabin commented Jan 12, 2023

Jenkins test please

@ctabin ctabin mentioned this pull request Jan 18, 2023
Closed
@ctabin
Copy link
Contributor Author

ctabin commented Jan 18, 2023

Any idea why the tests are failing ? My changes shouldn't have any impact other than avoiding request to oracle's servers... 🤔

@Pandrex247 Pandrex247 changed the base branch from Payara6 to master January 23, 2023 09:58
@breakponchito
Copy link
Contributor

Jenkins test please

@breakponchito
Copy link
Contributor

Jenkins test please

@breakponchito breakponchito self-requested a review January 24, 2023 15:33
breakponchito
breakponchito approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@breakponchito breakponchito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breakponchito breakponchito added the PR: DO NOT MERGE Don't merge PR until further notice label Jan 25, 2023
@breakponchito
Copy link
Contributor

Thank you very much for your contribution

@breakponchito breakponchito merged commit b127d21 into payara:master Jan 25, 2023
@breakponchito breakponchito removed the PR: DO NOT MERGE Don't merge PR until further notice label Jan 25, 2023
@JamesHillyard JamesHillyard changed the title Migration to Jakarta Persistence 3.0 namespace for EJB Timer services FISH-7024 Migration to Jakarta Persistence 3.0 namespace for EJB Timer services Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breakponchito breakponchito breakponchito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctabin @pzygielo @breakponchito