Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-6962 Follow the rename from #5957/FISH-5827 #6133

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

pzygielo
Copy link
Contributor

Currently during the build following is logged:

[INFO] --- jaxb2-maven-plugin:2.4:schemagen (schemagen) @ microprofile-metrics ---
[INFO] Ignored given or default sources [src/main/java/fish/payara/microprofile/metrics/jmx/MBeanMetadataConfig.java], since it is not an existent file or directory.
[INFO] Ignored given or default sources [src/main/java/fish/payara/microprofile/metrics/jmx/MBeanMetadataConfig.java], since it is not an existent file or directory.
[WARNING] 
+=================== [Incorrect Plugin Configuration Detected]
|
| Property : sources
| Problem  : At least one Java Source file has to be included.
|
+=================== [End Incorrect Plugin Configuration Detected]

After change from this PR:

[INFO] --- jaxb2-maven-plugin:2.4:schemagen (schemagen) @ microprofile-metrics ---
[INFO] Created EpisodePath [.../appserver/payara-appserver-modules/microprofile/metrics/target/generated-resources/schemagen/META-INF/JAXB]: true
[INFO] Created EpisodePath [.../appserver/payara-appserver-modules/microprofile/metrics/target/generated-resources/schemagen/META-INF/JAXB]: true
warning: Supported source version 'RELEASE_7' from annotation processor 'com.sun.tools.jxc.ap.SchemaGenerator' less than -source '1.8'
Note: Writing .../schema1.xsd
Note: Writing .../appserver/payara-appserver-modules/microprofile/metrics/target/generated-resources/schemagen/META-INF/JAXB/episode_schemagen.xjb
Note: Writing .../appserver/payara-appserver-modules/microprofile/metrics/target/generated-resources/schemagen/META-INF/JAXB/episode_schemagen.xjb
warning: Implicitly compiled files were not subject to annotation processing.
  Use -proc:none to disable annotation processing or -implicit to specify a policy for implicit compilation.
[INFO] XSD post-processing: Adding JavaDoc annotations in generated XSDs.
[INFO] Processing [1] java sources.

@smillidge smillidge added PR: CLA CLA submitted on PR by the contributor Type: Community Contribution labels Jan 4, 2023
@pzygielo

This comment was marked as outdated.

@JamesHillyard
Copy link
Member

Jenkins test please

@JamesHillyard JamesHillyard changed the title Follow the rename from #5957/FISH-5827 FISH-6962 Follow the rename from #5957/FISH-5827 Jan 19, 2023
@pzygielo

This comment was marked as outdated.

@JamesHillyard
Copy link
Member

Jenkins test please

@pzygielo

This comment was marked as outdated.

@JamesHillyard
Copy link
Member

Jenkins test please

@pzygielo
Copy link
Contributor Author

Maybe I should rebase? This looks terrible now.

@JamesHillyard
Copy link
Member

Hi @pzygielo, The rebase seems to have worked correctly however GitHub is displaying the changes incorrectly. I suspect this is something to do with it not updating what it thinks the Payara master branch is. Please do feel free to rebase yourself or close this issue and raise another based on current master if you would prefer.

I have reviewed these changes and they look good so will be merged after Jenkins has successfully passed

@pzygielo
Copy link
Contributor Author

Rebased, and GH is showing 1 changed file again.

@JamesHillyard
Copy link
Member

Jenkins test please

@JamesHillyard JamesHillyard merged commit 4bd3877 into payara:master Jan 25, 2023
@pzygielo pzygielo deleted the incorrect-plugin branch January 25, 2023 09:10
@JamesHillyard
Copy link
Member

Thank you very much for this fix and your prompt replies, it's much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: CLA CLA submitted on PR by the contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants