Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-6022 FISH-6299 FISH-6047: Payara 6 port for JWT and SSO issues #6076

Merged
merged 4 commits into from
Nov 28, 2022

Conversation

pdudits
Copy link
Contributor

@pdudits pdudits commented Nov 25, 2022

Port of #6021 and #6053 for Payara6

…equire realm name to be set

Explicitly assosiate first session with object, do not rely on that to be side effect of creating session
at just the right time.

Do not enable SSO when realm name is empty such as with JASPIC applications, as
that would enable it before any two applications even if their means of authentications
are incompatible
@pdudits pdudits requested a review from aubi November 25, 2022 08:44
@pdudits
Copy link
Contributor Author

pdudits commented Nov 25, 2022

Jenkins test please

@pdudits
Copy link
Contributor Author

pdudits commented Nov 25, 2022

Jenkins test please

1 similar comment
@pdudits
Copy link
Contributor Author

pdudits commented Nov 25, 2022

Jenkins test please

@Pandrex247 Pandrex247 merged commit 3a1955e into payara:Payara6 Nov 28, 2022
Pandrex247 added a commit to Pandrex247/Payara that referenced this pull request Nov 30, 2022
Pandrex247 added a commit that referenced this pull request Nov 30, 2022
Revert "Merge pull request #6076 from pdudits/fish-6022-6047-p6"
Pandrex247 added a commit to Pandrex247/Payara that referenced this pull request Jan 10, 2023
Pandrex247 added a commit that referenced this pull request Jan 10, 2023
Revert "Merge pull request #6076 from pdudits/fish-6022-6047-p6"
Pandrex247 added a commit to Pandrex247/Payara that referenced this pull request Jan 10, 2023
Pandrex247 added a commit to Pandrex247/Payara that referenced this pull request Jan 12, 2023
@Softwaremanufaktur
Copy link

@Pandrex247 @pdudits

Is there a chance to get to know why the commit/merge of https://github.com/payara/Payara/pull/6021/files was reverted here? (Same project which initially opened the issue #5746 but new developer. We again have the same behaviour as mentioned in the issue with Version 6.2023.6

@Pandrex247
Copy link
Member

It was initially reverted because it broke the MicroProfile TCK: #6141
Looking at the commit history, I'm now not sure if we ever revisited it for Payara 6 (the fix at the time was written for the Payara 5 branch).

Please feel free to raise an issue if you're still encountering the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants