FISH-6066 Invalid property 'default-web-xml' on instance start-up #6074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JamesHillyard <james.hillyard@payara.fish>
|
Jenkins test please |
|
Jenkins test please |
Pandrex247
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When starting a new instance, the following warning is logged:
Ignoring invalid property default-web-xml = /home/james/workspace/payara5/glassfish/nodes/localhost-domain1/Dull-Piranha/config/default-web.xmlThis fix prevents this from happening and sets the default-web.xml property. This changes nothing functionally, as this property is already correctly configured by the time it reaches
vs.setDefaultWebXmlLocation(value);. This also explains why it was observed this warning doesn't impact any functionality on the server.Important Info
Blockers
N/A
Testing
New tests
N/A
Testing Performed
Started the server, created a new instance and observed the logs.
Testing Environment
Windows 10, Maven 3.6.3, JDK 8
Documentation
N/A