Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-6596 Jakarta Form Data #6054

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Conversation

aubi
Copy link
Contributor

@aubi aubi commented Nov 17, 2022

Description

Improvements for JakartaEE 8 applications running on Payara 6, original idea is #5842

This PR is the opposite part to #6031, which improved support of Java EE 9 apps on Payara 5.

The only change happens in jsf-uncompressed.js
All jakarta.faces.* post data is duplicated with javax.faces copies.

E.g. the reproducer application produced this output:

form: form
form:input: Message
jakarta.faces.behavior.event: action
jakarta.faces.partial.ajax: true
jakarta.faces.partial.event: click
jakarta.faces.partial.execute: form:jsfButton form:input
jakarta.faces.partial.render: form:output
jakarta.faces.source: form:jsfButton
jakarta.faces.ViewState: 3768650063610317665:-4574714117490412382

The new version produces this:

form: form
form:input: Message
javax.faces.ViewState: 1818319852855307414:-2863703350972090453
javax.faces.source: form:jsfButton
jakarta.faces.source: form:jsfButton
javax.faces.partial.event: click
jakarta.faces.partial.event: click
javax.faces.partial.execute: form:jsfButton form:input
jakarta.faces.partial.execute: form:jsfButton form:input
javax.faces.partial.render: form:output
jakarta.faces.partial.render: form:output
javax.faces.behavior.event: action
jakarta.faces.behavior.event: action
javax.faces.partial.ajax: true
jakarta.faces.partial.ajax: true
jakarta.faces.ViewState: 1818319852855307414:-2863703350972090453

Testing

Testing Performed

Reproducer attached to the issue: #5842
Deploy to Payara, open http://localhost:8080/Jakarta9-1.0-SNAPSHOT/ fill some data to the edit and click JSF button. Watch request details in the browser's Developer Tools in the Network tab. Details are in Mojarra PR: payara/patched-src-mojarra#18

Testing Environment

OpenJDK 11, Linux

Notes for Reviewers

Depends on patched Mojarra PR: payara/patched-src-mojarra#18

duplicate jakarta form data with javax prefix
@aubi aubi requested a review from arieki November 17, 2022 00:49
@aubi
Copy link
Contributor Author

aubi commented Nov 17, 2022

Jenkins test please

@aubi
Copy link
Contributor Author

aubi commented Nov 17, 2022

Jenkins test please

1 similar comment
@breakponchito
Copy link
Contributor

Jenkins test please

Copy link
Contributor

@breakponchito breakponchito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aubi aubi merged commit f21eb6e into payara:Payara6 Nov 17, 2022
@aubi aubi deleted the FISH-6596-javax-form-data-p6 branch November 17, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants