Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FISH-6047: Fix Single Sing On handling for Jaspic applications, Single Sign Off for all SSO-enabled apps #6053

Merged
merged 1 commit into from
Nov 21, 2022
Merged

FISH-6047: Fix Single Sing On handling for Jaspic applications, Single Sign Off for all SSO-enabled apps #6053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...erver/web/web-core/src/main/java/org/apache/catalina/authenticator/AuthenticatorBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,6 +768,9 @@ protected void register(HttpRequest request, HttpResponse response, Principal pr
assert (realm != null);
sso.register(value, principal, authType, username, password, realm);
// END S1AS8 PE 4856080,4918627
if (session != null) {
sso.associate(value, 0, session);
}

request.setNote(Constants.REQ_SSOID_NOTE, value);
if (sso.isVersioningSupported()) {
Expand Down Expand Up @@ -807,6 +810,9 @@ public void logout(HttpRequest request) throws ServletException {
if (session != null) {
session.setPrincipal(null);
session.setAuthType(null);
if (session.getSsoId() != null) {
session.expire();
}
}

// principal and authType set to null in the following
Expand Down
2 changes: 1 addition & 1 deletion ...ver/web/web-glue/src/main/java/com/sun/enterprise/security/web/GlassFishSingleSignOn.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ public int invoke(final Request request, final Response response) {
}

String realmName = realm.getRealmName();
if (realmName == null) {
if (realmName == null || realmName.isEmpty()) {
// S1AS8 6155481 START
if (logger.isLoggable(Level.FINE)) {
logger.log(Level.FINE, LogFacade.NO_REALM_CONFIGURED);
Expand Down