FISH-6499 Fix NPE on Redeployment When No Default Web Module Set #6022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Pielage <andrew.pielage@payara.fish>
Signed-off-by: Andrew Pielage <andrew.pielage@payara.fish>
Signed-off-by: Andrew Pielage <andrew.pielage@payara.fish>
|
Jenkins test please |
|
Jenkins test please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a NPE when redeploying an application when no default web module on the virtual server has been set.
Important Info
Blockers
None
Testing
New tests
New test under payara-samples/asadmin.
Testing Performed
Started domain.
Deployed
Testing Environment
WSL, Zulu JDK 8, 11, and 17
Documentation
N/A
Notes for Reviewers
I massively struggled to get a simple test case of passing the
applications.dirproperty to Payara through arquillian to allow testing of the deploy command in this manner. I've gave up on Windows - thecreate-system-propertiescommand splits on colons (which of course Windows has in its path), and also escapes on backslashes (again, Windows paths). The setup for payara-server-managed is also weird WRT setting payara.home, so I've left that alone as well.