FISH-6606 Use Temporary Filename Only While Saving the Uploaded File #6014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test please |
Pandrex247
approved these changes
Nov 3, 2022
|
Jenkins test please |
1 similar comment
|
Jenkins test please |
aubi
force-pushed
the
FISH-6606-fix-empty-uploaded-file
branch
from
cb7ccdc
to
53c3147
Compare
|
Jenkins test please |
Upgrade of common-upload probably changed the behaviour of saving file, now it fails if the target file already exists. Now, we use only the filename. The temp file is still created as Java always creates it, it is deleted before the uploaded file is written.
aubi
force-pushed
the
FISH-6606-fix-empty-uploaded-file
branch
from
0455145
to
b4e2503
Compare
aubi
force-pushed
the
FISH-6606-fix-empty-uploaded-file
branch
from
3f68bf9
to
6c784e0
Compare
|
Fixes #6020 |
|
When can we expect Payara 2022.4 with this patch to download. |
|
Hi @AleksanderBastl, Payara Community Edition 5.2022.5 is currently scheduled for December 2022, however I can't guarantee an exact release date. Alternatively, you could opt to build Payara locally to utilise this bug fix early, instructions on building Payara are documented here: https://docs.payara.fish/community/docs/General%20Info/Build%20Instructions.html Best Regards, |
|
Thank you for quick answer and solution for my question. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing issue with empty ear/war file during deployment via admin gui and uploading file
Upgrade of common-upload probably changed the behaviour of saving file, now it fails if the target file already exists. Now, we use only the filename.
The temp file is still created as Java always creates it, it is deleted before the uploaded file is written.
Important Info
Testing
Testing Performed
Upload the file attached to the Jira ticket, basically any ear/war should be deployable via upload.
Process:
Testing Environment
Linux, OpenJDK 8, 11