FISH-6588 Embedded EJB Container NPE Fix #6008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
|
Jenkins test please |
2 similar comments
|
Jenkins test please |
|
Jenkins test please |
|
Port of #6007 |
|
Jenkins test please |
Pandrex247
deleted the
FISH-6588-PayaraExecutorService-Fix-No-Revert-P6
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug fix for the
PayaraExecutorServiceencountering NPEs during use in an Embedded EJB Container.With
ApplicationLoaderServicenow starting at run level 15 rather tha 10, this meant theALL_APPLICATIONS_LOADEDevent was firing later than before, leading to the thread pools in thePayaraExecutorServicestill being null during the "half-restarts" that occur when using the Embedded EJB Container.These "half-restarts" only re-initialise some services, not all, which was leading to the thread pools in
PayaraExecutorServicebeing nulled from receiving theSERVER_SHUTDOWNevent, but never being reinitialised.Since the
SERVER_STARTevent doesn't get fired until after run-level 10 (our NPE happens at run-level 10), I've created a new event to get fired after run-level 1.Important Info
Blockers
None
Testing
See #6007
Documentation
N/A
Notes for Reviewers
See #6007