Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FISH-6495 : setting hazelcast property when passed #6006

Merged
merged 1 commit into from
Nov 1, 2022
Merged

FISH-6495 : setting hazelcast property when passed #6006

merged 1 commit into from
Nov 1, 2022

Conversation

luiseufrasio
Copy link
Contributor

Description

A customer would like to provide a path to a hazelcast configuration file when using Payara Embedded with Arquillian.

Testing

New tests

None

Testing Performed

  1. Download the attached reproducer application & hazelcast-config.xml
  2. Modify the embedded arquillian configuration in arquillian.xml to specify a path to the hazelcast-text.xml file: 

<container qualifier="payara-embedded" default="true">
    <configuration>
        <property name="bindHttpPort">9990</property>
        <property name="hazelcastConfigurationFile">C:/Users/luise/Downloads/hazelcast-test.xml</property>
    </configuration>
</container>
3. Run the test with mvn clean install and the test should pass

Testing Environment

Zulu JDK 1.8_212 on Windows 10 with Maven 3.8.4

@luiseufrasio
Copy link
Contributor Author

jenkins test please

1 similar comment
@luiseufrasio
Copy link
Contributor Author

jenkins test please

@Pandrex247
Copy link
Member

Jenkins test please

Pandrex247
Pandrex247 approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@Pandrex247 Pandrex247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue resolved.
Would be nice if the automated test was placed somewhere, even if just under appserver/tests

@luiseufrasio
Copy link
Contributor Author

jenkins test please

@luiseufrasio luiseufrasio merged commit 5046d41 into payara:Payara6 Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pandrex247 Pandrex247 Pandrex247 approved these changes

@jGauravGupta jGauravGupta Awaiting requested review from jGauravGupta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luiseufrasio @Pandrex247