FISH-6430: skipping BdId TransactionalExtension type to not generate error logs #5963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test please |
...er/web/weld-integration/src/main/java/org/glassfish/weld/services/InjectionServicesImpl.java
Outdated
Show resolved
Hide resolved
|
Jenkins test please |
|
Jenkins test please |
breakponchito
changed the title
|
Jenkins test please |
|
Jenkins test please |
3 similar comments
|
Jenkins test please |
|
Jenkins test please |
|
Jenkins test please |
Pandrex247
reviewed
Sep 28, 2022
...er/web/weld-integration/src/main/java/org/glassfish/weld/services/InjectionServicesImpl.java
Outdated
Show resolved
Hide resolved
...er/web/weld-integration/src/main/java/org/glassfish/weld/services/InjectionServicesImpl.java
Outdated
Show resolved
Hide resolved
|
Jenkins test please |
2 similar comments
|
Jenkins test please |
|
Jenkins test please |
Pandrex247
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix to prevent error logs related to inject TransactionalScopedCDIEventHelperImpl for TransactionScoped CDI Beans
Important Info
Blockers
Testing
New tests
Testing Performed
local testing using the attached reproducer (adjusted to be compatible with most recent version of jakarta) from the ticket: FISH-6430
logs looks more cleaned:
`[#|2022-09-27T12:01:10.483-0500|INFO|Payara 6.2022.1.Alpha5-SNAPSHOT|javax.enterprise.system.core|_ThreadID=145;_ThreadName=admin-thread-pool::admin-listener(1);_TimeMillis=1664298070483;_LevelValue=800;|
simple-ear was successfully deployed in 3,935 milliseconds.|#]
[#|2022-09-27T12:02:04.044-0500|INFO|Payara 6.2022.1.Alpha5-SNAPSHOT||_ThreadID=131;_ThreadName=http-thread-pool::http-listener-1(3);_TimeMillis=1664298124044;_LevelValue=800;|
ServiceBean::doWork() called|#]
[#|2022-09-27T12:02:10.350-0500|INFO|Payara 6.2022.1.Alpha5-SNAPSHOT||_ThreadID=131;_ThreadName=http-thread-pool::http-listener-1(3);_TimeMillis=1664298130350;_LevelValue=800;|
TestTransactionalScopeBean initialized. Value is 1664298130350|#]
[#|2022-09-27T12:02:59.559-0500|INFO|Payara 6.2022.1.Alpha5-SNAPSHOT||_ThreadID=131;_ThreadName=http-thread-pool::http-listener-1(3);_TimeMillis=1664298179559;_LevelValue=800;|
ServiceBean:: testTransactionalScope value is 1664298130350|#]
[#|2022-09-27T12:03:17.772-0500|INFO|Payara 6.2022.1.Alpha5-SNAPSHOT||_ThreadID=131;_ThreadName=http-thread-pool::http-listener-1(3);_TimeMillis=1664298197772;_LevelValue=800;|
NestedServiceBean::doWork() called|#]
[#|2022-09-27T12:03:17.773-0500|INFO|Payara 6.2022.1.Alpha5-SNAPSHOT||_ThreadID=131;_ThreadName=http-thread-pool::http-listener-1(3);_TimeMillis=1664298197773;_LevelValue=800;|
NestedServiceBean:: testTransactionalScope value is 1664298130350|#]
[#|2022-09-27T12:04:24.385-0500|WARNING|Payara 6.2022.1.Alpha5-SNAPSHOT|com.hazelcast.internal.cluster.impl.ClusterHeartbeatManager|_ThreadID=228;_ThreadName=hz.suspicious_bouman.cached.thread-29;_TimeMillis=1664298264385;_LevelValue=900;|
[172.21.41.173]:4900 [development] [5.1.1] Resetting heartbeat timestamps because of huge system clock jump! Clock-Jump: 43667 ms, Heartbeat-Timeout: 60000 ms|#]
[#|2022-09-27T12:04:26.968-0500|INFO|Payara 6.2022.1.Alpha5-SNAPSHOT||_ThreadID=131;_ThreadName=http-thread-pool::http-listener-1(3);_TimeMillis=1664298266968;_LevelValue=800;|
TestTransactionalScopeBean destroyed. Value is 1664298130350|#]`
Testing Environment
Ubuntu 20.04, Azul JDK 11, Maven 3.8.6
Documentation
Notes for Reviewers