Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FISH-6238 Microprofile Interceptors [@Fallback@/CircuitBreaker] are not getting invoked if the EJB is a @Stateless Bean #5947

Merged
merged 2 commits into from
Sep 21, 2022
Merged

FISH-6238 Microprofile Interceptors [@Fallback@/CircuitBreaker] are not getting invoked if the EJB is a @Stateless Bean #5947

merged 2 commits into from
Sep 21, 2022

Conversation

arieki
Copy link
Contributor

@arieki arieki commented Sep 20, 2022

Description

This is a fix for #5679 issue.
EJB life-cycle failed to recognize programmatic interceptor regarding fault-tolerance interceptor that is using around invoke interception type

Important Info

Blockers

N/A

Testing

New tests

Testing Performed

  • Build payara server with build extras profile -PBuildExtras
  • Checkout this reproducer
  • Change fish.payara.extras:payara-embedded-all payara-sample's dependency version to fixed payara which is 6.2022.1.Alpha5-SNAPSHOT
    example:
<dependency>
  <groupId>fish.payara.extras</groupId>
  <artifactId>payara-embedded-all</artifactId>
  <version>6.2022.1.Alpha5-SNAPSHOT</version>
  <scope>test</scope>
</dependency>
  • Run mvn clean test

or

  • Run mvn clean install of reproducers module on payara-samples/samples

Testing Environment

Windows 11, OpenJDK11, Maven 3.8.4

Documentation

None

Notes for Reviewers

None

@arieki
FISH-6238 Support programmatic interceptor
97b14d9 
session bean failed to recognize programmatic interceptor regarding fault-tolerance interceptor that is using around invoke interception type

Signed-off-by: Arie Kiswanto <arie.kiswanto@payara.fish>

# Conflicts:
#	appserver/web/weld-integration/src/main/java/org/glassfish/weld/services/EjbServicesImpl.java
@arieki
FISH-6238 Add aroundInvoke annotation and reproducers module
8eacf14 
# Conflicts:
#	appserver/payara-appserver-modules/microprofile/fault-tolerance/src/main/java/fish/payara/microprofile/faulttolerance/cdi/FaultToleranceInterceptor.java
#	appserver/tests/payara-samples/samples/pom.xml
#	appserver/tests/payara-samples/samples/reproducers/pom.xml
@arieki
Copy link
Contributor Author

arieki commented Sep 20, 2022

jenkins test please

@arieki arieki merged commit 0908b50 into payara:Payara6-tck Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdudits pdudits pdudits approved these changes

@Pandrex247 Pandrex247 Awaiting requested review from Pandrex247

@jGauravGupta jGauravGupta Awaiting requested review from jGauravGupta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arieki @pdudits