FISH-6512 Jakarta Annotations 2.1.1 (Payara6 Branch) #5928
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Pielage <andrew.pielage@payara.fish>
Signed-off-by: Andrew Pielage <andrew.pielage@payara.fish>
|
Jenkins test please |
|
Quicklook passes for me locally ¯\_(ツ)_/¯ |
|
Jenkins test please |
1 similar comment
|
Jenkins test please |
This reverts commit dd0acdc. Packing jakarta.json-api appears to kill all suites on Jenkins, despite it working locally on multiple machines.
Pandrex247
changed the title
|
Jenkins test please |
|
Merged into TCK Branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Jakarta Annotations to 2.1.1 to pass the signature test.
Important Info
Blockers
None
Testing
New tests
None
Testing Performed
See #5927
Testing Environment
WSL OpenSUSE Leap 15.4, Zulu JDK 11.0.16
Documentation
N/A
Notes for Reviewers
The signature TCK also seemingly requires the
--add-opens=java.base/jdk.internal.vm.annotation=ALL-UNNAMEDJVM option to be enabled server-side. I'm looking at adding this to the runner rather than enabling it by default in the domain since it seems very specific.