FISH-6483 add several other js require in admingui #5913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test, please |
|
Jenkins test please |
|
Jenkins test, please |
|
@arieki |
I believe you want to mention @luiseufrasio instead |
|
Jenkins test please |
Create fake object with id and value, so it passes various checks. Later, when module is loaded, the checks are done correctly.
aubi
force-pushed
the
FISH-6347-fix-table-requires
branch
from
de15808
to
6b04d53
Compare
|
Jenkins test please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added require for function calls on table, so they succeed.
Currently, there is no (known) JS warning in the log while working with admin gui.
There is only 404 for a js file (will be consecutive PR).
Important Info
Testing
Testing Performed
Going through admin gui (e.g. select list of JDBC resources, go to detail, ping, deploy application, etc.)
Testing Environment
Linux, OpenJDK 11
Notes for Reviewers
Open JS debugger while going through admin gui and watch uncatched exceptions.