FISH-6352 File locks prevent undeployment on Windows #5832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jGauravGupta
changed the title
|
jenkins test please |
MarkWareham
approved these changes
Jul 1, 2022
|
jenkins test please |
1 similar comment
|
jenkins test please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Undeployment of an application takes a long time on Payara6 on Windows.
Fix
This issue is caused by the NPE exception thrown in the stop operation of WebappClassloader which results in an uncleaned classloader and locking in Windows.
NPE exception is caused during cleaning the cache of BeanELResolver.properties field via Reflection API which is now changed from static to non-static, and that already fixes the cache issue as per the following ticket details.
BeanELResolver needs cleanup method · Issue #171 · jakartaee/expression-language
Fix #171. Make cache per instance rather than per class · jakartaee/expression-language@3ec9258
Testing
Testing Performed
Java EE 7 Samples