Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fish 6301 "Enable Asadmin Recorder" button is not visible #5793

Merged
merged 4 commits into from
Jun 7, 2022

Conversation

luiseufrasio
Copy link
Contributor

Description

The "Enable Asadmin Recorder" button is not visible in the header of the Admin Console

Important Info

Blockers

None

Testing

New tests

None

Testing Performed

  1. mvn clean install -DskipTests
  2. ./appserver/distributions/payara/target/stage/payara6/bin/asadmin start-domain
  3. Open localhost:4848 in a web browser
  4. Check if the button appears

Testing Environment

Zulu JDK 11 on Ubuntu 18.04 with Maven 3.8.4

@luiseufrasio
Copy link
Contributor Author

jenkins test please

Copy link
Contributor

@MarkWareham MarkWareham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like buttons simply moved

Copy link
Contributor

@arieki arieki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luiseufrasio luiseufrasio merged commit 4de223a into payara:Payara6 Jun 7, 2022
@luiseufrasio luiseufrasio deleted the FISH-6301 branch June 7, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants