-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FISH-6034 Rework Eclipse Transformer Integration into an Extension #5790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <andrew.pielage@payara.fish>
Signed-off-by: Andrew Pielage <andrew.pielage@payara.fish>
Signed-off-by: Andrew Pielage <andrew.pielage@payara.fish>
Signed-off-by: Andrew Pielage <andrew.pielage@payara.fish>
Signed-off-by: Andrew Pielage <andrew.pielage@payara.fish>
Signed-off-by: Andrew Pielage <andrew.pielage@payara.fish>
aubi
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jenkins test please |
Jenkins test please |
1 similar comment
Jenkins test please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reworks the Payara Jakarta EE Eclipse Transformer integration into an extension, loaded via ServiceLoader.
Important Info
Blockers
PR to create API and Implementation extensions: payara/transformer#26
Release of API.
Testing
New tests
None
Testing Performed
Ran
simple-servlet
servlet test of Java EE 7 samples (Payara6 branch):fish.payara.deployment.transform.namespace=true
- passedfish.payara.deployment.transform.namespace=false
- passedRan
simple-servlet
servlet test of Java EE 7 samples (master branch):fish.payara.deployment.transform.namespace=true
- passedfish.payara.deployment.transform.namespace=false
- failed (expected)Testing Environment
Windows 10, Zulu JDK 8
Documentation
payara/Payara-Community-Documentation#313
Notes for Reviewers
To review:
internal-api
and install it into your local maven repodeployment-transformer-impl
extension topayara6/glassfish/modules