Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-6034 Rework Eclipse Transformer Integration into an Extension #5790

Merged
merged 9 commits into from
Jul 21, 2022

Conversation

Pandrex247
Copy link
Member

@Pandrex247 Pandrex247 commented Jun 6, 2022

Description

Reworks the Payara Jakarta EE Eclipse Transformer integration into an extension, loaded via ServiceLoader.

Important Info

Blockers

PR to create API and Implementation extensions: payara/transformer#26
Release of API.

Testing

New tests

None

Testing Performed

Ran simple-servlet servlet test of Java EE 7 samples (Payara6 branch):

  • Without extension implementation - passed
  • With extension implementation - passed
  • With extension implementation and fish.payara.deployment.transform.namespace=true - passed
  • With extension implementation and fish.payara.deployment.transform.namespace=false - passed

Ran simple-servlet servlet test of Java EE 7 samples (master branch):

  • Without extension implementation - failed (expected)
  • With extension implementation - passed
  • With extension implementation and fish.payara.deployment.transform.namespace=true - passed
  • With extension implementation and fish.payara.deployment.transform.namespace=false - failed (expected)

Testing Environment

Windows 10, Zulu JDK 8

Documentation

payara/Payara-Community-Documentation#313

Notes for Reviewers

To review:

  • Build the internal-api and install it into your local maven repo
  • Check out the deployment-transformer-1.0 tag and build it using JDK 11.
  • Build Payara Server
  • Add the deployment-transformer-impl extension to payara6/glassfish/modules

Pandrex247 and others added 7 commits May 27, 2022 17:31
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <andrew.pielage@payara.fish>
Signed-off-by: Andrew Pielage <andrew.pielage@payara.fish>
Signed-off-by: Andrew Pielage <andrew.pielage@payara.fish>
Signed-off-by: Andrew Pielage <andrew.pielage@payara.fish>
Signed-off-by: Andrew Pielage <andrew.pielage@payara.fish>
@Pandrex247 Pandrex247 marked this pull request as ready for review June 6, 2022 15:24
Signed-off-by: Andrew Pielage <andrew.pielage@payara.fish>
Copy link
Contributor

@aubi aubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jGauravGupta
Copy link
Contributor

Jenkins test please

@Pandrex247
Copy link
Member Author

Jenkins test please

1 similar comment
@Pandrex247
Copy link
Member Author

Jenkins test please

@Pandrex247 Pandrex247 merged commit c41e566 into payara:Payara6 Jul 21, 2022
@Pandrex247 Pandrex247 deleted the FISH-6034 branch July 21, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants