Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.13.3 broke builds #154

Closed
ofek opened this issue Sep 25, 2020 · 4 comments · Fixed by #155
Closed

0.13.3 broke builds #154

ofek opened this issue Sep 25, 2020 · 4 comments · Fixed by #155
Labels
unconfirmed This bug was not reproduced yet

Comments

@ofek
Copy link
Contributor

ofek commented Sep 25, 2020

Hello again!

Describe the bug

https://github.com/DataDog/integrations-core/pull/7660/checks?check_run_id=1164408408

ERROR   -  Error reading page 'base/api.md': get_handler() got an unexpected keyword argument 'rendering' 
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/runner/work/integrations-core/integrations-core/.tox/docs/lib/python3.8/site-packages/mkdocs/__main__.py", line 192, in <module>
    cli()
  File "/home/runner/work/integrations-core/integrations-core/.tox/docs/lib/python3.8/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/runner/work/integrations-core/integrations-core/.tox/docs/lib/python3.8/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/runner/work/integrations-core/integrations-core/.tox/docs/lib/python3.8/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/runner/work/integrations-core/integrations-core/.tox/docs/lib/python3.8/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/runner/work/integrations-core/integrations-core/.tox/docs/lib/python3.8/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/runner/work/integrations-core/integrations-core/.tox/docs/lib/python3.8/site-packages/mkdocs/__main__.py", line 152, in build_command
    build.build(config.load_config(**kwargs), dirty=not clean)
  File "/home/runner/work/integrations-core/integrations-core/.tox/docs/lib/python3.8/site-packages/mkdocs/commands/build.py", line 271, in build
    _populate_page(file.page, config, files, dirty)
  File "/home/runner/work/integrations-core/integrations-core/.tox/docs/lib/python3.8/site-packages/mkdocs/commands/build.py", line 171, in _populate_page
    page.render(config, files)
  File "/home/runner/work/integrations-core/integrations-core/.tox/docs/lib/python3.8/site-packages/mkdocs/structure/pages.py", line 175, in render
    self.content = md.convert(self.markdown)
  File "/home/runner/work/integrations-core/integrations-core/.tox/docs/lib/python3.8/site-packages/markdown/core.py", line 263, in convert
    root = self.parser.parseDocument(self.lines).getroot()
  File "/home/runner/work/integrations-core/integrations-core/.tox/docs/lib/python3.8/site-packages/markdown/blockparser.py", line 90, in parseDocument
    self.parseChunk(self.root, '\n'.join(lines))
  File "/home/runner/work/integrations-core/integrations-core/.tox/docs/lib/python3.8/site-packages/markdown/blockparser.py", line 105, in parseChunk
    self.parseBlocks(parent, text.split('\n\n'))
  File "/home/runner/work/integrations-core/integrations-core/.tox/docs/lib/python3.8/site-packages/markdown/blockparser.py", line 123, in parseBlocks
    if processor.run(parent, blocks) is not False:
  File "/home/runner/work/integrations-core/integrations-core/.tox/docs/lib/python3.8/site-packages/mkdocstrings/extension.py", line 155, in run
    xml_element = self.process_block(identifier, str(block))
  File "/home/runner/work/integrations-core/integrations-core/.tox/docs/lib/python3.8/site-packages/mkdocstrings/extension.py", line 183, in process_block
    handler = get_handler(
  File "/home/runner/work/integrations-core/integrations-core/.tox/docs/lib/python3.8/site-packages/mkdocstrings/handlers/__init__.py", line 244, in get_handler
    handlers_cache[name] = module.get_handler(theme, custom_templates, **config)  # type: ignore
TypeError: get_handler() got an unexpected keyword argument 'rendering'

Additional context

Did we do something incorrectly?

@florimondmanca
Copy link
Contributor

Looks like this is due to python.py:get_handler() not accepting **kwargs anymore: https://github.com/pawamoy/mkdocstrings/blob/8371e9456278d872f52cbc0b6d4f6d9d81055a8b/src/mkdocstrings/handlers/python.py#L248-L252 :-)

Introduced in this commit: 2537314

@pawamoy
Copy link
Member

pawamoy commented Sep 25, 2020

Woops 😰

Looks like I broke it indeed! My apologies!

@pawamoy
Copy link
Member

pawamoy commented Sep 25, 2020

Just released 0.13.4 that fixes the issue. Thank you @ofek and @florimondmanca, and sorry again for the broken builds!

@florimondmanca
Copy link
Contributor

florimondmanca commented Sep 25, 2020

Thanks for promptly jumping in and releasing a new version, @pawamoy! :-) Appreciate your work on this project, as always!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unconfirmed This bug was not reproduced yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants