Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back arbitrary **config to Python handler #155

Merged

Conversation

florimondmanca
Copy link
Contributor

@florimondmanca florimondmanca commented Sep 25, 2020

Closes #154

I'm not sure if this is what we want, or if we want to not pass **config in the parent get_handler() implementation, but either of these should resolve the bug showcased in #154.

https://github.com/florimondmanca/mkdocstrings/blob/25373148699daad42b319fa04213d405ca8a7c4c/src/mkdocstrings/handlers/__init__.py#L244


PS: I wasn't able to run make setup (I don't have 3.6 and 3.7 installed, and pinning PYTHON_VERSIONS = ("3.8",) results in a strange error I couldn't find the cause of…

$ make setup
Setting up Python 3.8 environment
---------------------------------
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
NameError: name 'PosixPath' is not defined
make: *** [setup] Error 1

@florimondmanca florimondmanca changed the title Bring back arbitrary **kwargs to Python handler Bring back arbitrary **config to Python handler Sep 25, 2020
@pawamoy
Copy link
Member

pawamoy commented Sep 25, 2020

Hello! Yeah I naively removed the **kwargs because they weren't used in the function, and it didn't fail on my side because I don't actually use any config on my autodoc instructions 😩

This definitely motivates me to finally write more tests 😅

@pawamoy
Copy link
Member

pawamoy commented Sep 25, 2020

About make setup, it's just a way to install environments for multiple Python version, but you can simply run poetry install instead (the things that run on multiple interpreters should be skipped then). I'll add this in the contributing docs, thanks 🙂

@pawamoy pawamoy merged commit fca7d4c into mkdocstrings:master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.13.3 broke builds
2 participants