-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: skip_files
is not OS-agnostic
#21
Comments
Good catch, thanks for the report! Should be an easy fix. Will get to it asap, PRs welcome in the meantime :) |
nfelt14
added a commit
to nfelt14/mkdocs-spellcheck
that referenced
this issue
Apr 30, 2024
…dcard pattern matching Also updates `skip_files` to treat file paths as OS-agnostic. Issue pawamoy#21: pawamoy#21 Issue pawamoy#20: pawamoy#20
@pawamoy I was able to get a PR up for this. |
Just to confirm, as it wasn't clear to me in the PR: is this fixed with your changes? |
My PR did fix this issue as a byproduct of the new feature. |
Ok great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the bug
The
skip_files
option accepts literal file paths, but when the file is checked it uses OS-specific file path separators, which means each file needs to be specified twice to work on Windows/Unix operating systems.To Reproduce
skip_files
option using Unix-style file path separatorsExpected behavior
The
skip_files
option should accept file paths using Unix-style file path separators and work on both Windows and Unix operating systems.Environment information
The text was updated successfully, but these errors were encountered: