Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, here is a cleaned up, further optimised and integrated new implementation of
dec!
. It is a completelyconst
and compile-time drop in replacement. This requires Rust 1.79.Your
Result<…String…>
is not destructible, i.e. not usable inconst
. Therefore the new parser has its ownResult
, that can be transparently converted by?
. This also required splittingtry_from_i128_with_scale
which thus became simpler.For now the parser does only exact in
i128
. Rounding should be addable, if you want to switch parsing completely to this.Being generic on a smaller type doesn’t currently seem possible in
const
. Should a benchmark show this to be slower than parsing intou64
, the old and new parsers might continue to coexist, till a solution is found.