Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul of the integration test suite #257

Merged
merged 29 commits into from
Sep 26, 2024
Merged

Overhaul of the integration test suite #257

merged 29 commits into from
Sep 26, 2024

Conversation

robomics
Copy link
Contributor

@robomics robomics added enhancement New feature or request testing Pull requests that perform updates to the test infrastructure labels Sep 20, 2024
@robomics robomics changed the title Overhaul of the integration test suiteTest/rewrite new Overhaul of the integration test suite Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 67.56757% with 12 lines in your changes missing coverage. Please review.

Project coverage is 71.94%. Comparing base (d2d6b0e) to head (049b7a0).
Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
src/hictk/cli/cli_balance.cpp 16.66% 3 Missing and 2 partials ⚠️
src/hictk/cli/cli_dump.cpp 0.00% 2 Missing ⚠️
src/hictk/convert/convert.cpp 0.00% 2 Missing ⚠️
src/hictk/cli/cli_convert.cpp 94.11% 0 Missing and 1 partial ⚠️
...nclude/hictk/balancing/impl/sparse_matrix_impl.hpp 0.00% 0 Missing and 1 partial ⚠️
.../filestream/include/hictk/impl/filestream_impl.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
- Coverage   73.60%   71.94%   -1.67%     
==========================================
  Files         147      147              
  Lines       13156    13508     +352     
  Branches     1560     1557       -3     
==========================================
+ Hits         9684     9718      +34     
- Misses       2205     2490     +285     
- Partials     1267     1300      +33     
Flag Coverage Δ
[tests integration](https://app.codecov.io/gh/paulsengroup/hictk/pull/257/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 62.14% <73.52%> (?)
[tests unittests](https://app.codecov.io/gh/paulsengroup/hictk/pull/257/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 51.63% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics force-pushed the test/rewrite-new branch 6 times, most recently from 61b3dfc to 8e9b2f2 Compare September 21, 2024 22:35
@robomics robomics force-pushed the test/rewrite-new branch 11 times, most recently from eb9145c to 56761d2 Compare September 23, 2024 13:42
@robomics
Copy link
Contributor Author

It would be good to get ccache working on Windows as well before merging...

@robomics robomics merged commit af60f39 into main Sep 26, 2024
89 of 91 checks passed
@robomics robomics deleted the test/rewrite-new branch September 26, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing Pull requests that perform updates to the test infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[testing] rewrite integration tests using python [ci] run integration tests as part of Windows CI
1 participant