Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fsevents 0.3.7 to avoid segmentation faults #332

Merged
merged 1 commit into from
Aug 10, 2015

Conversation

pmq20
Copy link
Contributor

@pmq20 pmq20 commented Aug 10, 2015

@@ -38,7 +38,7 @@
"sinon-chai": "^2.6.0"
},
"optionalDependencies": {
"fsevents": "^0.3.1"
"fsevents": ">= 0.3.7 < 1"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^0.3.7

@es128
Copy link
Contributor

es128 commented Aug 10, 2015

This is unnecessary. ^0.3.1 will already install the latest 0.3.x automatically, and the only thing existing projects need to do is npm update.

@es128 es128 closed this Aug 10, 2015
@paulmillr paulmillr reopened this Aug 10, 2015
paulmillr added a commit that referenced this pull request Aug 10, 2015
Use fsevents 0.3.7 to avoid segmentation faults
@paulmillr paulmillr merged commit cfa1d99 into paulmillr:master Aug 10, 2015
@paulmillr
Copy link
Owner

Doesn't bring any disadvantages tho!

@nickdesaulniers
Copy link

if you can publish a new version number, folks reinstalling watchify will get unblocked, see: browserify/watchify#257 (comment)

@es128
Copy link
Contributor

es128 commented Aug 25, 2015

@nickdesaulniers shouldn't matter. npm update (or at worst rm -rf node_modules && npm i) should be sufficient to pull in latest fsevents.

master branch is failing tests in CI currently, want to resolve before the next publish

@nickdesaulniers
Copy link

yep, thanks!

@es128
Copy link
Contributor

es128 commented Sep 18, 2015

Doesn't bring any disadvantages tho!

Turns out it does. It confuses lots of users thinking they need to wait for us to publish rather than just updating deps and letting semver do its thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants