Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow undefined in options #1396

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Fuzzyma
Copy link

@Fuzzyma Fuzzyma commented Dec 17, 2024

see #1394 for more details

@Fuzzyma
Copy link
Author

Fuzzyma commented Jan 13, 2025

I dont have windows and cant check the failing test. Is it a race condition or an actual issue? Can we rerun the test?

@pralkarz
Copy link

I dont have windows and cant check the failing test. Is it a race condition or an actual issue? Can we rerun the test?

I ran the tests on Windows 10 with Node v.20.18.1, everything seems to have passed, but only with node test.mjs (the same command as the one used by the CI). npm test didn't work for me, failing multiple cases.

ℹ tests 183
ℹ suites 59
ℹ pass 183
ℹ fail 0
ℹ cancelled 0
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 55246.6835

@43081j
Copy link
Collaborator

43081j commented Jan 14, 2025

windows still has some flakiness in tests thanks to some double events. i dont remember exactly what off the top of my head but a re-run made this pass for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants