-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple and pluggable content encryption keys and encryption algorithms #2240
Open
vierbergenlars
wants to merge
11
commits into
paulcwarren:main
Choose a base branch
from
vierbergenlars:encryption-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support multiple and pluggable content encryption keys and encryption algorithms #2240
vierbergenlars
wants to merge
11
commits into
paulcwarren:main
from
vierbergenlars:encryption-refactor
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow configuration of all pluggable components and provide default values when nothing is configured
…ccessor interface
We need to ensure that the accessor is able to read the content property from the entity before it is removed/after it is created. This is necessary to have custom key accessors work, so they can store the encryption key somewhere other than the entity itself, for example based on the content id
vierbergenlars
force-pushed
the
encryption-refactor
branch
from
January 21, 2025 12:37
47c5a15
to
5e29104
Compare
This DataEncryptionKeyWrapper object needs to be instanciated by users to use vault encryption, so it should not be in the internal package
vierbergenlars
added a commit
to vierbergenlars/spring-content-gettingstarted
that referenced
this pull request
Jan 21, 2025
The encryption module has been updated in paulcwarren/spring-content#2240
Note that builds against the getting-started repo are failing due to a refactor of the encryption classes. (I have opened a PR there to update the example as well) |
vierbergenlars
force-pushed
the
encryption-refactor
branch
from
January 23, 2025 16:02
c81148a
to
4fd3695
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the content encryption module to support:
Provided implementations:
byte[]
field in the entity next to the content property, with any custom suffix