don't try to override members that are privateWithin anything #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnhoekstra
commented
May 21, 2024
jvm/src/test/scala/org/scalamock/test/scalatest/DefaultAccessMock.scala
Outdated
Show resolved
Hide resolved
martijnhoekstra
force-pushed
the
mock-default-access
branch
from
4e10c24 to
987ce28
Compare
martijnhoekstra
force-pushed
the
mock-default-access
branch
from
987ce28 to
7921158
Compare
|
Hi, thank you for your contribution, this one is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Purpose
When a class have package-private members, we can't override those. This is the case among other things for default access java methods. Check privateWithin to determine whether we can override.
Background Context
References
Are there any relevant issues / PRs / mailing lists discussions?