Skip to content

Commit

Permalink
Revert of [interpeter] Move to table based peephole optimizer. (patch…
Browse files Browse the repository at this point in the history
…set v8#38 id:730001 of https://codereview.chromium.org/2118183002/ )

Reason for revert:
Break MIPS port.

Original issue's description:
> [interpeter] Move to table based peephole optimizer.
>
> Introduces a lookup table for peephole optimizations.
>
> Fixes some tests using BytecodePeepholeOptimizer::Write() that should
> have been update to use BytecodePeepholeOptimizer::WriteJump().
>
> BUG=v8:4280
> LOG=N
>
> Committed: https://crrev.com/f4234422b93b21a286b0f31799009bcbe8b90b9e
> Cr-Commit-Position: refs/heads/master@{#37819}

TBR=rmcilroy@chromium.org,machenbach@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4280

Review-Url: https://codereview.chromium.org/2161563002
Cr-Commit-Position: refs/heads/master@{#37821}
  • Loading branch information
ohodson authored and Commit bot committed Jul 18, 2016
1 parent c06ad08 commit eae4016
Show file tree
Hide file tree
Showing 11 changed files with 271 additions and 798 deletions.
49 changes: 0 additions & 49 deletions BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ if (v8_enable_gdbjit == "") {
}
}

v8_generated_peephole_source = "$target_gen_dir/bytecode-peephole-table.cc"
v8_random_seed = "314159265"
v8_toolset_for_shell = "host"

Expand Down Expand Up @@ -650,25 +649,6 @@ action("run_mksnapshot") {
}
}

action("run_mkpeephole") {
visibility = [ ":*" ] # Only targets in this file can depend on this.

deps = [ ":mkpeephole($v8_snapshot_toolchain)" ]

outputs = [ v8_generated_peephole_source ]

sources = []

script = "tools/run.py"

args = [
"./" + rebase_path(get_label_info(":mkpeephole($v8_snapshot_toolchain)",
"root_out_dir") + "/mkpeephole",
root_build_dir),
rebase_path(v8_generated_peephole_source, root_build_dir),
]
}

action("v8_dump_build_config") {
script = "tools/testrunner/utils/dump_build_config.py"
outputs = [
Expand Down Expand Up @@ -1331,7 +1311,6 @@ v8_source_set("v8_base") {
"src/interpreter/bytecode-label.h",
"src/interpreter/bytecode-peephole-optimizer.cc",
"src/interpreter/bytecode-peephole-optimizer.h",
"src/interpreter/bytecode-peephole-table.h",
"src/interpreter/bytecode-pipeline.cc",
"src/interpreter/bytecode-pipeline.h",
"src/interpreter/bytecode-register-allocator.cc",
Expand Down Expand Up @@ -1930,9 +1909,6 @@ v8_source_set("v8_base") {
":v8_libsampler",
]

sources += [ v8_generated_peephole_source ]
deps += [ ":run_mkpeephole" ]

if (is_win) {
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
cflags = [ "/wd4267" ]
Expand Down Expand Up @@ -2156,31 +2132,6 @@ if (current_toolchain == v8_snapshot_toolchain) {
}
}

v8_executable("mkpeephole") {
# mkpeephole needs to be built for the build host so the peephole lookup
# table can built during build. The table depends on the properties of
# bytecodes that are described in bytecodes.{cc,h}.
visibility = [ ":*" ] # Only targets in this file can depend on this.

sources = [
"src/interpreter/bytecode-peephole-optimizer.h",
"src/interpreter/bytecodes.cc",
"src/interpreter/bytecodes.h",
"src/interpreter/mkpeephole.cc",
]

configs = [
":external_config",
":internal_config",
]

deps = [
":v8_libbase",
"//build/config/sanitizers:deps",
"//build/win:default_exe_manifest",
]
}

###############################################################################
# Public targets
#
Expand Down
Loading

0 comments on commit eae4016

Please sign in to comment.