Skip to content

Commit

Permalink
[build] Add force_dynamic_crt option to build a static library with /…
Browse files Browse the repository at this point in the history
…MD on windows

Adds option to build a V8 library statically, but with the options on
windows that allows it to be subsequently included in another DLL. On
Windows this is required for it to correclty link against the correct
C++ runtime. Require for our Node.js shared library build.

Reference:  nodejs/node#7487

BUG=
R=machenbach@chromium.org, michael_dawson@ca.ibm.com

Review-Url: https://codereview.chromium.org/2149963002
Cr-Commit-Position: refs/heads/master@{#37814}
  • Loading branch information
sxa authored and Commit bot committed Jul 18, 2016
1 parent 7e4e6c5 commit 9cf88c1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions gypfiles/standalone.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
'includes': ['toolchain.gypi'],
'variables': {
'component%': 'static_library',
'force_dynamic_crt%': 0,
'clang_xcode%': 0,
# Track where uninitialized memory originates from. From fastest to
# slowest: 0 - no tracking, 1 - track only the initial allocation site, 2
Expand Down
6 changes: 3 additions & 3 deletions gypfiles/toolchain.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -1110,7 +1110,7 @@
'VCCLCompilerTool': {
'Optimization': '0',
'conditions': [
['component=="shared_library"', {
['component=="shared_library" or force_dynamic_crt==1', {
'RuntimeLibrary': '3', # /MDd
}, {
'RuntimeLibrary': '1', # /MTd
Expand Down Expand Up @@ -1162,7 +1162,7 @@
'StringPooling': 'true',
'BasicRuntimeChecks': '0',
'conditions': [
['component=="shared_library"', {
['component=="shared_library" or force_dynamic_crt==1', {
'RuntimeLibrary': '3', #/MDd
}, {
'RuntimeLibrary': '1', #/MTd
Expand Down Expand Up @@ -1353,7 +1353,7 @@
'FavorSizeOrSpeed': '0',
'StringPooling': 'true',
'conditions': [
['component=="shared_library"', {
['component=="shared_library" or force_dynamic_crt==1', {
'RuntimeLibrary': '2', #/MD
}, {
'RuntimeLibrary': '0', #/MT
Expand Down

0 comments on commit 9cf88c1

Please sign in to comment.