Properly handle falsey defaults

paul-mannino · Nov 19, 2024 · a3e2485 · a3e2485
1 parent 53ac0df
commit a3e2485
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/lib/tapioca/dsl/compilers/inexact_struct.rb b/lib/tapioca/dsl/compilers/inexact_struct.rb
@@ -33,7 +33,7 @@ def sorted_parameters
       def parameters
         constant.props.map do |name, prop|
           type = prop.fetch(:type_object).to_s
-          if prop[:default]
+          if !prop[:default].nil?
             create_kw_opt_param(name.to_s, type: type, default: 'T.unsafe(nil)')
           elsif T::Props::Utils.optional_prop?(prop)
             create_kw_opt_param(name.to_s, type: type, default: 'nil')

diff --git a/spec/fixtures/bar.rbi b/spec/fixtures/bar.rbi
diff --git a/spec/inexact_struct_spec.rb b/spec/inexact_struct_spec.rb
@@ -13,7 +13,7 @@ class Foo < T::InexactStruct
   class Bar < Foo
     const :x, T::Boolean
     const :y, T.nilable(String)
-    const :z, T.any(Integer, T::Boolean)
+    const :z, T.any(Integer, T::Boolean), default: false
   end
 
   class Baz < T::InexactStruct