Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topology - Aggregating edges between node groups #30

Draft
wants to merge 1 commit into
base: v4
Choose a base branch
from
Draft

Topology - Aggregating edges between node groups #30

wants to merge 1 commit into from

Conversation

jpinsonneau
Copy link
Collaborator

@jpinsonneau jpinsonneau commented Apr 11, 2023 •
edited
Loading

Solve #17

image
image

TODOs:

  • node <-> group
  • between groups with same nesting depth
  • complex nesting depth cases between different parents
    • group <-> subgroup
    • subgroup <-> subgroup
    • subnode + subgroup <-> group

jeff-phillips-18
jeff-phillips-18 reviewed Apr 11, 2023
View reviewed changes
packages/module/src/utils/svg-utils.ts Outdated
/**
* @param polyPoints
* @param hullPadding
*/
export function hullPath(polyPoints: PointTuple[], hullPadding: number | HullPaddingGetter = 0): string {
export function hullPath(polyPoints: PointTuple[], hullPadding: number | HullPaddingGetter = 0): { path: string, segments?: PointTuple[][] } {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the return for an exported function is a breaking change. We could either add a new function or this would have to go into V5.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure @jeff-phillips-18, let's keep hullPath as is dc07574

Only hullPathAndSegments function will return both path and segments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-phillips-18 jeff-phillips-18 jeff-phillips-18 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpinsonneau @jeff-phillips-18