Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init a contribution guide #38

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Init a contribution guide #38

merged 3 commits into from
Sep 13, 2023

Conversation

fhlavac
Copy link
Collaborator

@fhlavac fhlavac commented Sep 12, 2023

README.md Outdated
|- ...
|- ...
|- ...
|- index.ts <<-- export * from './MyNewComponent';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will have to map the default export

export * from './MyNewComponent';
export { default as MyNewComponent } from './MyNewComponent';

The index.ts can be also generated if the convention is strictly followed and enforced

@fhlavac fhlavac merged commit 521a280 into patternfly:main Sep 13, 2023
4 checks passed
@fhlavac fhlavac deleted the guide branch September 13, 2023 13:50
@github-actions
Copy link

🎉 This PR is included in version 1.0.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Nov 1, 2023

🎉 This PR is included in version 5.0.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants