-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export types for all available components #37
Conversation
@@ -80,7 +80,7 @@ export interface BatteryProps extends React.DetailedHTMLProps<React.HTMLAttribut | |||
className?: string; | |||
} | |||
|
|||
const Battery: React.FunctionComponent<BatteryProps> = ({ severity, label, labelHidden, className, ...props }: BatteryProps) => { | |||
export const Battery: React.FunctionComponent<BatteryProps> = ({ severity, label, labelHidden, className, ...props }: BatteryProps) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The batter props are not exported still
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hyperkid123 I think they are, but I may be missing something.
@@ -1,5 +1,4 @@ | |||
export { default } from './Battery'; | |||
export { default as Battery } from './Battery'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to test the imports in a test environment. We don't want to loose any of these references. We are only looking for the extra types reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hyperkid123 do you think it is safer not to remove these explicit exports? I can add them back, maybe it's better to keep them explicitly listed. When testing that, haven't found any issues
🎉 This PR is included in version 1.0.16 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 5.0.0-prerelease.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
RHCLOUD-28237