Export types for all available components #37
Conversation
| @@ -80,7 +80,7 @@ export interface BatteryProps extends React.DetailedHTMLProps<React.HTMLAttribut | |||
| className?: string; | |||
| } | |||
|
|
|||
| const Battery: React.FunctionComponent<BatteryProps> = ({ severity, label, labelHidden, className, ...props }: BatteryProps) => { | |||
| export const Battery: React.FunctionComponent<BatteryProps> = ({ severity, label, labelHidden, className, ...props }: BatteryProps) => { | |||
There was a problem hiding this comment.
The batter props are not exported still
There was a problem hiding this comment.
@Hyperkid123 I think they are, but I may be missing something.
| @@ -1,5 +1,4 @@ | |||
| export { default } from './Battery'; | |||
| export { default as Battery } from './Battery'; | |||
There was a problem hiding this comment.
Make sure to test the imports in a test environment. We don't want to loose any of these references. We are only looking for the extra types reference.
There was a problem hiding this comment.
@Hyperkid123 do you think it is safer not to remove these explicit exports? I can add them back, maybe it's better to keep them explicitly listed. When testing that, haven't found any issues
|
🎉 This PR is included in version 1.0.16 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.0.0-prerelease.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
RHCLOUD-28237