-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gallery to the about page #366
Changes from 2 commits
87dd01d
5465d4b
2cfcb31
e10f1dd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -4,14 +4,27 @@ id: About component groups | |||||
sortValue: 1 | ||||||
sourceLink: https://github.com/patternfly/react-component-groups/blob/main/packages/module/patternfly-docs/content/extensions/component-groups/about-component-groups.md | ||||||
--- | ||||||
import { SectionGallery } from '@patternfly/documentation-framework/components/sectionGallery/sectionGallery'; | ||||||
import galleryData from './gallery-data.json'; | ||||||
|
||||||
Component groups lives in its own package [`@patternfly/react-component-groups`](https://www.npmjs.com/package/@patternfly/react-component-groups) | ||||||
|
||||||
# Component groups | ||||||
|
||||||
The component groups extension contains a range of React components that are more complex than basic PatternFly components. These component groups combine and adjust multiple base components to provide opinionated solutions for recurring use cases across products using PatternFly. | ||||||
The component groups extension contains a range of React components that are more complex than basic PatternFly components. These component groups combine and adjust multiple base components to provide opinionated solutions for recurring use cases across products using PatternFly. | ||||||
|
||||||
The creation and maintenance of this extension is a collaborative effort between the PatternFly and Red Hat Hybrid Cloud Console teams. All component groups receive accessibility and design reviews, and we are working to improve internationalization, add unit test coverage, and ensure that CSS overrides all correctly reference the PatternFly CSS API. | ||||||
The creation and maintenance of this extension is a collaborative effort between the PatternFly and Red Hat Hybrid Cloud Console teams. All component groups receive accessibility and design reviews, and we are working to improve internationalization, add test coverage, and ensure that CSS overrides all correctly reference the PatternFly CSS API. | ||||||
|
||||||
Below, you can see a gallery of categories representing the components: | ||||||
|
||||||
<SectionGallery | ||||||
section="Component groups" | ||||||
galleryItemsData={galleryData} | ||||||
placeholderText="Search component groups by name" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
maybe we can just remove the search bar for now, since there's not a lot to filter through? but if that's a lot of work, it's doing no harm by being there! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @edonehoo the gallery component does not allow it yet. We may want to talk to @nicolethoen about the possibility of adding that configuration. |
||||||
includeSubsections={true} | ||||||
hasGridText={true} | ||||||
isFullWidth={false} | ||||||
/> | ||||||
|
||||||
**Note:** This extension replaces [`RedHatInsights/frontend-components`](https://github.com/RedHatInsights/frontend-components). If you previoulsy used `frontend-components`, you can refer to [this migration guide](https://github.com/patternfly/react-component-groups/blob/main/migration.md) to help you transition to `react-component-groups`. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
What do you think about moving this up to line 11 or so? Right below the note about the package location. Just to make sure it's easy to spot There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sounds good! |
||||||
|
||||||
|
@@ -25,4 +38,4 @@ Specific contribution guidelines and instructions are outlined in [the component | |||||
|
||||||
We aim to align the standards of component groups as closely as possible with existing PatternFly standards. Given that this is a multi-team collaboration, we will continue to work towards this goal together. | ||||||
|
||||||
If you notice a bug or have a suggestion for a new component group, feel free to file an issue in our [GitHub repository](https://github.com/patternfly/react-component-groups/issues)! Please make sure to check if there is already a pre-existing issue before creating a new issue. | ||||||
If you notice a bug or have a suggestion for a new component group, open an issue in our [GitHub repository](https://github.com/patternfly/react-component-groups/issues)! Please make sure to check if there is already a pre-existing issue before creating a new one. |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,17 @@ | ||||||
{ | ||||||
"content-containers": { | ||||||
"summary": "Provide layout components to organize and display content in structured and flexible formats." | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
}, | ||||||
"controls": { | ||||||
"summary": "Include components that manage user interactions and input, enabling intuitive navigation and selection." | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
}, | ||||||
"error-communication": { | ||||||
"summary": "Contain various error and alert states to communicate issues or restrictions." | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
}, | ||||||
"helpers": { | ||||||
"summary": "Offer utility components that enhance usability and provide additional guidance or information within the UI." | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
}, | ||||||
"status-and-state-indicators": { | ||||||
"summary": "Visualize entity states, statuses, and loading indicators to inform users of system conditions or processes." | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
} | ||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.