New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(table): add inline editing + buttons #1428

Closed

atiratree wants to merge 1 commit into patternfly:master from atiratree:table-inline-edit

atiratree commented Feb 15, 2019

Hello,

these are the styles for pf-react Table (patternfly/patternfly-react#1227).

It was inspired by pf3 inline-edit (https://github.com/patternfly/patternfly-react/blob/aa839a80a005f5d540faeb0e1a0320b7df1cc982/packages/patternfly-3/patternfly-react/less/inline-edit.less)

few issues:

I didn't put the confirmation buttons into the examples because their location is computed (depends on scroll and resize)
not sure if the colors should be the same as in pf3 (light/dark theme?)
the borders seem to misbehave in firefox


          feat(table): add inline editing + buttons

f4f630c

atiratree mentioned this pull request

feat(Table): support inline editing in PF4 patternfly/patternfly-react#1227

Merged

6 tasks

Author

atiratree commented Feb 28, 2019

this PR has a lower priority and the styles were temporarily moved to pf-react (after a recent discussion)

for future reference: there is a bug in firefox which breaks the table borders: https://bugzilla.mozilla.org/show_bug.cgi?id=688556

atiratree closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet