Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Avatar): Penta updates #9954

Merged
merged 1 commit into from
Jan 17, 2024
Merged

feat(Avatar): Penta updates #9954

merged 1 commit into from
Jan 17, 2024

Conversation

tlabaj
Copy link
Contributor

@tlabaj tlabaj commented Jan 9, 2024

What: Closes #9880

@tlabaj tlabaj requested review from a team, wise-king-sullyman, mfrances17 and mattnolting and removed request for a team January 9, 2024 22:37
@tlabaj tlabaj mentioned this pull request Jan 9, 2024
Closed
@patternfly-build
Copy link
Contributor

patternfly-build commented Jan 9, 2024 •
edited
Loading

Preview: https://patternfly-react-pr-9954.surge.sh

A11y report: https://patternfly-react-pr-9954-a11y.surge.sh

@tlabaj tlabaj linked an issue Jan 10, 2024 that may be closed by this pull request
Consume core Penta updates: Avatar #9880
Closed
wise-king-sullyman
wise-king-sullyman approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@wise-king-sullyman wise-king-sullyman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will we want a codemod for the prop change? edit: missed that you already made a codemod issue!

@lboehling
Copy link
Collaborator

lgtm!

@tlabaj tlabaj removed the request for review from a team January 12, 2024 16:28
srambach
srambach approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄

@thatblindgeye thatblindgeye merged commit c9e3b72 into patternfly:v6 Jan 17, 2024
13 checks passed
@thatblindgeye thatblindgeye mentioned this pull request Jan 17, 2024
Closed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@6.0.0-alpha.14
  • @patternfly/react-core@6.0.0-alpha.14
  • @patternfly/react-docs@7.0.0-alpha.14
  • @patternfly/react-integration@6.0.0-alpha.9
  • demo-app-ts@5.1.1-alpha.13
  • @patternfly/react-table@6.0.0-alpha.14

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@srambach srambach srambach approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

@mfrances17 mfrances17 Awaiting requested review from mfrances17 mfrances17 was automatically assigned from patternfly/react-reviewers

@mattnolting mattnolting Awaiting requested review from mattnolting mattnolting was automatically assigned from patternfly/core-in-react-reviewers

Assignees
No one assigned
Labels
css review ux review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consume core Penta updates: Avatar
6 participants
@tlabaj @patternfly-build @lboehling @wise-king-sullyman @srambach @thatblindgeye