Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Masthead): Consume Penta tokens #9853

Merged
merged 2 commits into from
Dec 20, 2023
Merged

chore(Masthead): Consume Penta tokens #9853

merged 2 commits into from
Dec 20, 2023

Conversation

tlabaj
Copy link
Contributor

@tlabaj tlabaj commented Dec 5, 2023

What: Closes #9809

Updated at Masthead demos and examples logos for light variation of masthead.

Note: Masthead: backgroundColor prop was removed in PR #9774 since light background is now the default with no option to change it.

@tlabaj tlabaj requested review from a team, mfrances17, kmcfaul, mmenestr and mattnolting and removed request for a team December 5, 2023 23:42
@tlabaj tlabaj changed the title Masthead penta chore(Masthead): Consume Penta tokens Dec 5, 2023
@patternfly-build
Copy link
Contributor

patternfly-build commented Dec 5, 2023 •
edited
Loading

Preview: https://patternfly-react-pr-9853.surge.sh

A11y report: https://patternfly-react-pr-9853-a11y.surge.sh

@tlabaj tlabaj mentioned this pull request Dec 6, 2023
Closed
@wise-king-sullyman wise-king-sullyman linked an issue Dec 6, 2023 that may be closed by this pull request
(Masthead): Add Penta tokens #9809
Closed
thatblindgeye
thatblindgeye approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some slight styling differences I'm noticing which may not necessarily be due to Masthead (the hamburger icon in examples is slightly bigger than Core examples, the link color is slightly different), but otherwise looks good react wise

mattnolting
mattnolting approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Opened #9897 as followup

packages/react-core/src/components/Masthead/examples/MastheadIconRouterLink.tsx Show resolved Hide resolved
@nicolethoen nicolethoen mentioned this pull request Dec 18, 2023
Closed
andrew-ronaldson
andrew-ronaldson approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Approved

@nicolethoen nicolethoen merged commit 51c3dac into patternfly:v6 Dec 20, 2023
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@6.0.0-alpha.7
  • @patternfly/react-core@6.0.0-alpha.7
  • @patternfly/react-docs@7.0.0-alpha.7
  • demo-app-ts@5.1.1-alpha.6
  • @patternfly/react-table@6.0.0-alpha.7

Thanks for your contribution! 🎉

@tlabaj tlabaj mentioned this pull request Jan 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitdallas gitdallas gitdallas approved these changes

@mattnolting mattnolting mattnolting approved these changes

@andrew-ronaldson andrew-ronaldson andrew-ronaldson approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

@mfrances17 mfrances17 Awaiting requested review from mfrances17 mfrances17 was automatically assigned from patternfly/react-reviewers

@kmcfaul kmcfaul Awaiting requested review from kmcfaul kmcfaul was automatically assigned from patternfly/react-reviewers

@mmenestr mmenestr Awaiting requested review from mmenestr mmenestr was automatically assigned from patternfly/ux-reviewers

Assignees
No one assigned
Labels
css review ux review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Masthead): Add Penta tokens
7 participants
@tlabaj @patternfly-build @gitdallas @mattnolting @andrew-ronaldson @thatblindgeye @nicolethoen