Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(TreeView): updated tests #9773

Merged
merged 4 commits into from
Nov 16, 2023
Merged

chore(TreeView): updated tests #9773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ef190c
chore(TreeView): updated tests
thatblindgeye Oct 23, 2023
b8dab4f
Added tests for TreeViewListItem
thatblindgeye Oct 24, 2023
5803b35
Added tests for TreeViewRoot and TreeView
thatblindgeye Oct 25, 2023
6e127e4
Updated snapshots and queries
thatblindgeye Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-core/src/components/TreeView/TreeViewListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ const TreeViewListItemBase: React.FunctionComponent<TreeViewListItemProps> = ({
<li
id={id}
className={css(styles.treeViewListItem, internalIsExpanded && styles.modifiers.expanded)}
{...(internalIsExpanded && { 'aria-expanded': 'true' })}
aria-expanded={internalIsExpanded}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aria-expanded should always be set with either true or false, not only when true, so this just fixes that.

role="treeitem"
tabIndex={-1}
>
Expand Down
Loading
Loading