fix(CatalogTileView): Support tiles without categories. #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PatternFly-React preview: https://977-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 3411
💛 - Coveralls |
mfrances17
reviewed
Nov 28, 2018
|
|
||
| if (item.approved) { | ||
| badges.push( | ||
| <CatalogTile.Badge key="certified" title="USDA Approved" id="approved"> |
There was a problem hiding this comment.
nit but i would order these the same as the certified badge - key/id/title
also is 'USDA' intended? would've thought simply Approved would be better
dtaylor113
previously approved these changes
Nov 29, 2018
jeff-phillips-18
dismissed stale reviews from dtaylor113 and mfrances17
via
3f0ebf9
jeff-phillips-18
force-pushed
the
catalog-tile-view
branch
from
2912dd2 to
3f0ebf9
Compare
|
Went for the extra-credit. @dtaylor113 @mfrances17 please take another look. |
mfrances17
approved these changes
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if tiles are added to the tile view and are not in a category they are displayed in a single tile per row rather than wrapped as they are when they are in a category.
This PR allows the caller to specify that categories are not used and will wrap the child tiles.