Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NotificationDrawer): demo conversion from JS to TS #9516

Merged
merged 7 commits into from
Sep 1, 2023

Conversation

adamviktora
Copy link
Contributor

What: Closes #9438

@patternfly-build
Copy link
Contributor

patternfly-build commented Aug 17, 2023

@nicolethoen
Copy link
Contributor

I cannot figure out why the ts -> js button is not appearing in the second demo and the site doesn't seem to think the second demo is written in ts... still looking into it, but maybe someone else here knows?

Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked into the above issue that Nicole mentioned, but I'd imagine we could update the js file=... to ts file=... in the MD file. Do you get the same issue as the Nav demo PR when doing so?

@thatblindgeye
Copy link
Contributor

@nicolethoen I wonder if it's just an issue with the preview... I tried editing my Org clone locally to add in the tsx example files to react-core (using js file=... in the MD), and the demos rendered with the correct "JS" icon in the example toolbar.

@kmcfaul
Copy link
Contributor

kmcfaul commented Aug 23, 2023

Maybe a rebase/rebuild would iron out the surge?

Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like its all working now!

@tlabaj tlabaj merged commit 4ebf8c8 into patternfly:main Sep 1, 2023
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@5.1.1-prerelease.3
  • @patternfly/react-core@5.1.1-prerelease.3
  • @patternfly/react-docs@6.1.1-prerelease.3
  • demo-app-ts@5.1.1-prerelease.2
  • @patternfly/react-table@5.1.1-prerelease.3

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert notification drawer react demos to TS
6 participants