feat(Progress): use max parameter to scale value of progress bar #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PatternFly-React preview: https://950-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 3389
💛 - Coveralls |
jschuler
reviewed
Nov 26, 2018
| limitedValue = value < min ? min : value; | ||
| limitedValue = limitedValue > max ? max : limitedValue; | ||
| const scaledValue = | ||
| max === 100 |
There was a problem hiding this comment.
can you put this in a function and add some test cases?
i tried out with value = 50, min = 50, max = 100 and got result 50 when I expected 0
There was a problem hiding this comment.
The min param still behaves as a minimum value for progress rather than a scaling factor as how max was changed. Should I also be changing how min works?
There was a problem hiding this comment.
Changing min parameter based on slack discussion.
kmcfaul
force-pushed
the
progress-bar-improvements
branch
from
2a64486 to
ff7760e
Compare
Previously, the max parameter acted as a hard limit to the progress value.
… core Changed logic to always show status icon if present regardless if label/value should be displayed. This matches behavior in pf-next.
Change scaling logic to account for both max and min, instead of only max.
kmcfaul
force-pushed
the
progress-bar-improvements
branch
from
ff7760e to
66f0a70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Change max parameter to control scaling of progress bar. Previously, it acted as a limit for the progress value.
Addresses issue: #945
Other notes: